(Shark 1.0) SD: Fix inpaint (+others) breakage on sharkification #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the @classmethod decorator to the base implementation of favored_base_models. This fixes running any SD pipeline that does not have a specific implementation of favored_base_models (everything but txt2img and txt2img_sdxl) break at the Sharkification stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Inpainting and (presumably other non txt2img operations) is currently breaking at the point where a
SharkifyStableDiffusionModelis constructed for the appropriate SD pipeline.Changes
favored_base_models. This stops running any SD pipeline that does not have a specific implementation of the method (everything but txt2img and txt2img_sdxl), breaking at the Sharkification stage.