(Shark 1.0) Fix setup_venv.ps1 not finding pinned torch-mlir #2062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adds a local file equivalent of https://llvm.github.io/torch-mlir/package-index/ containing links to the pinned torch_mlir versions (links taken from the torch-mlir releases github page). * Use the local file instead of the real package index in setup_venv.ps1.
|
Awesome! Thanks for this. |
|
It may need some tweaking for Linux and/or exe builds but generally a good start. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2061
Motivation
The version of torch-mlir pinned by d35288e seems to have dropped off of https://llvm.github.io/torch-mlir/package-index/ so
.\setup-venv.ps1fails to install it.Changes
Possible Problems/Concerns
setup-venv.shscript as the original commit didn't touch that.