Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PC-9893: Change time_to_burn_entire_budget measurement operator for alerting #89

Merged

Conversation

nuusk
Copy link
Contributor

@nuusk nuusk commented Aug 1, 2023

TLDR

This PR changed operator for time_to_burn_entire_budget measurement.

Motivation

Reason lte is better suited than lt is that with thte maximum possible exhaustion we're going to be predicting the burn of Total Error Budget Allowance.

Copy link
Contributor

@nobl9-adam-szymanski nobl9-adam-szymanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nuusk added a commit to nobl9/terraform-provider-nobl9 that referenced this pull request Aug 2, 2023
A recent PR to nobl9-go (nobl9/nobl9-go#89) changed the required operator for time_to_burn_entire_budget to lte (from lt).
This PR reflects that change in the provider.
@nobl9-adam-szymanski nobl9-adam-szymanski changed the title Change time_to_burn_entire_budget measurement operator for alerting PC-9893: Change time_to_burn_entire_budget measurement operator for alerting Aug 2, 2023
@nobl9-adam-szymanski nobl9-adam-szymanski merged commit 859369f into main Aug 2, 2023
3 checks passed
@nobl9-adam-szymanski nobl9-adam-szymanski deleted the PC-9893-change-entire-exhaustion-operator branch August 2, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants