Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of get_ref() #184

Merged
merged 10 commits into from
Jan 20, 2016
Merged

Implementation of get_ref() #184

merged 10 commits into from
Jan 20, 2016

Conversation

dariomt
Copy link
Contributor

@dariomt dariomt commented Jan 18, 2016

As per discussion about issue #128

@nlohmann
Copy link
Owner

Hi @dariomt, thanks for the PR. Could you please have a look at the issues raised by Travis?

@nlohmann nlohmann added this to the Release 1.0.1 milestone Jan 18, 2016
@dariomt
Copy link
Contributor Author

dariomt commented Jan 19, 2016

The travis failures seem related to missing typename

Hum... the error says:

error: need ‘typename’ before ‘std::add_pointer<ReferenceType>::type’ because ‘std::add_pointer<ReferenceType>’ is a dependent scope
   using PointerType = std::add_pointer<ReferenceType>::type;

I thought typename was not needed in a using context, because the compiler knows I'm asking for a type there! Doh!

I can only test my changes locally with MSVC.
Is there a way to test my changes on clang/gcc remotely before making the PR?

@dariomt
Copy link
Contributor Author

dariomt commented Jan 19, 2016

Trying to compile in VS2015 I get the errors shown in appveyor (test\catch.hpp(1575): error C2056: illegal expression)
It seems some change in catch.hpp is problematic :(
But this should be failing in master too!

Oh! I see this is issue #167
I'll try to fix the gcc/clang problems "playing by ear" :)

@dariomt
Copy link
Contributor Author

dariomt commented Jan 19, 2016

OK, now both clang and gcc are happy! :)
I'll wait for #167 to be resolved before checking the MSVC status.

nlohmann added a commit that referenced this pull request Jan 20, 2016
Implementation of get_ref()
@nlohmann nlohmann merged commit 663ad13 into nlohmann:master Jan 20, 2016
@nlohmann
Copy link
Owner

Thanks a lot!

nlohmann added a commit that referenced this pull request Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants