generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(button-login): add button login (LUX-147) #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discrepancies from original design: the playground is at the bottom of the page instead of inline. We will fix that later on.
remypar5
commented
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nog toevoegen:
- States
- Agents
- Languages
- Toegankelijkheid
packages/storybook/src/web-components/button-login/button-login.md
Outdated
Show resolved
Hide resolved
packages/storybook/src/web-components/button-login/button-login.md
Outdated
Show resolved
Hide resolved
packages/storybook/src/web-components/button-login/button-login.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Echt tof om te lezen. Heb wat comments achter gelaten.
AlineNap
approved these changes
Apr 24, 2024
remypar5
changed the title
docs(button-login): add button login
docs(button-login): add button login (LUX-147)
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ik heb geprobeerd om de Playground tussen de tekst te zetten, zoals in het design is weergegeven. Dat lukt mij niet, ondanks het volgen van de Storbyook documentatie. Nu staat de Playground onderaan de tekst en laten we het zo. Er is een story aangemaakt om dit later op te kunnen pakken