Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(button-login): add button login (LUX-147) #42

Merged
merged 8 commits into from
Apr 24, 2024

Conversation

remypar5
Copy link
Contributor

@remypar5 remypar5 commented Apr 11, 2024

Ik heb geprobeerd om de Playground tussen de tekst te zetten, zoals in het design is weergegeven. Dat lukt mij niet, ondanks het volgen van de Storbyook documentatie. Nu staat de Playground onderaan de tekst en laten we het zo. Er is een story aangemaakt om dit later op te kunnen pakken

Discrepancies from original design: the playground is at the bottom of the page instead of inline. We will fix that later on.
@remypar5 remypar5 self-assigned this Apr 11, 2024
@remypar5 remypar5 enabled auto-merge (squash) April 11, 2024 10:15
Copy link
Contributor Author

@remypar5 remypar5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nog toevoegen:

  • States
  • Agents
  • Languages
  • Toegankelijkheid

Copy link

@jeffreylauwers jeffreylauwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echt tof om te lezen. Heb wat comments achter gelaten.

@remypar5 remypar5 removed the request for review from rwittenberns April 16, 2024 09:48
@remypar5 remypar5 changed the title docs(button-login): add button login docs(button-login): add button login (LUX-147) Apr 24, 2024
@remypar5 remypar5 merged commit a3157bc into main Apr 24, 2024
6 checks passed
@remypar5 remypar5 deleted the docs/LUX-147-add-button-login branch April 24, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants