generated from nl-design-system/example
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(LUX-29): new component: login-method-button #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleeuwen
reviewed
Mar 8, 2024
De CI pipeline faalt nog op het |
rwittenberns
requested changes
Mar 14, 2024
packages/web-components-stencil/src/components/login-method-button/login-method-button.tsx
Outdated
Show resolved
Hide resolved
packages/web-components-stencil/src/components/login-method-button/login-method-button.tsx
Outdated
Show resolved
Hide resolved
packages/web-components-stencil/src/components/login-method-button/login-method-button.tsx
Outdated
Show resolved
Hide resolved
packages/web-components-stencil/src/components/login-method-button/login-method-button.tsx
Outdated
Show resolved
Hide resolved
packages/web-components-stencil/src/components/login-method-button/login-method-button.tsx
Show resolved
Hide resolved
…tton/login-method-button.tsx Co-authored-by: rwittenberns <85627716+rwittenberns@users.noreply.github.com>
…ystem/lux into feat/new-component-list-item
Een handmatige review is uitgevoerd door een UX designer uit een ander team. De volgende bevindingen moeten worden behandeld:
|
…component-list-item
rwittenberns
previously approved these changes
Mar 19, 2024
rwittenberns
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reviewers:
method
seems unsuitable. If you have a suggestion, please provide it.logius
namespace whereas the common and component tokens have thelux
namespace. This is deliberateclick
event and replaces it with aluxClick
event. This is to make sure the internals of the component (which is protected by the shadowDom) don't get exposed. We are still debating whether or not to do this.