Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(LUX-29): new component: login-method-button #15

Merged
merged 15 commits into from
Mar 20, 2024

Conversation

remypar5
Copy link
Contributor

@remypar5 remypar5 commented Mar 6, 2024

For reviewers:

  • The name of the component became the topic of discussion again. Since this is a button which directs you to a "middel" instead of a "manier", the term method seems unsuitable. If you have a suggestion, please provide it.
  • There are no tests, yet, and are out of scope for this PR.
  • Currently, Storybook's preview.tsx shows both dark and default/light mode. That will change later to a theme switcher.
  • The core tokens have the logius namespace whereas the common and component tokens have the lux namespace. This is deliberate
  • The component catches and stops the HTML click event and replaces it with a luxClick event. This is to make sure the internals of the component (which is protected by the shadowDom) don't get exposed. We are still debating whether or not to do this.

@rwittenberns
Copy link
Contributor

De CI pipeline faalt nog op het pnpm run build:style-dictionary command

remypar5 and others added 4 commits March 14, 2024 11:36
…tton/login-method-button.tsx

Co-authored-by: rwittenberns <85627716+rwittenberns@users.noreply.github.com>
…ystem/lux into feat/new-component-list-item
@remypar5
Copy link
Contributor Author

remypar5 commented Mar 15, 2024

Een handmatige review is uitgevoerd door een UX designer uit een ander team. De volgende bevindingen moeten worden behandeld:

  • Icon
    • alignment/padding
    • Icon is te groot
    • Digid icon
      • border color lijkt af te wijken van design
      • border radius is korrelig
  • Focus state
    • outline color (light)
    • outline color (dark)
    • wordt ook toegepast bij active state
  • Border color
    • alle states (light)
    • alle states (dark)
  • line-height is niet gezet
  • Labels
    • eIDAS
    • Eherkenning

rwittenberns
rwittenberns previously approved these changes Mar 19, 2024
@matijs matijs merged commit ef4eefd into main Mar 20, 2024
6 checks passed
@matijs matijs deleted the feat/new-component-list-item branch March 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants