Only use legacy signed MathNet.Numerics wrapper on Framework and older Standard #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctually need that
|
Unfortunate that they have two variants. It's so much easier to just sign the assembly even for modern .NET use and let it ignore the fact. If I remember correctly the advice (at some point at least) was that sign the assembly and have the public key public in repo (don't expect it to be a secret). |
|
@lahma yes, signing in itself is generally useless but harmless, and they've added a "PublicSigning" option to simplify that too - the problem is that Mathnet.Numerics has two different packages with conflicting names paces, and they specifically advise use of the unsigned variant except for the handful of cases that actually have a use for signing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.Net Framework cares about legacy "Strong Naming" which is why #785 was opened in 2022, but it's not useful for Core - this PR makes it conditional, so Framework and Standard 2.0 users get that signed variant, Standard 2.1 and Core 6 will get the normal package instead resolving #1365 without upsetting legacy people.