Merge pull request #1408 from wuzxc1230123/fix/SXSSFWorkbook

fix: update \r ASCII/UTF
nissl-lab · Aug 28, 2024 · 93b88c3 · 93b88c3
2 parents 282c9e5 + 690af39
commit 93b88c3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/ooxml/XSSF/Streaming/SheetDataWriter.cs b/ooxml/XSSF/Streaming/SheetDataWriter.cs
@@ -471,12 +471,19 @@ protected void OutputQuotedString(string s)
                         break;
                     // Special characters
                     case '\n':
+                        if(counter > last)
+                        {
+                            WriteAsBytes(GetSubArray(chars, last, counter - last));
+                        }
+                        WriteAsBytes("&#xa;");
+                        last = counter + 1;
+                        break;
                     case '\r':
                         if (counter > last)
                         {
                             WriteAsBytes(GetSubArray(chars, last, counter - last));
                         }
-                        WriteAsBytes("&#xa;");
+                        WriteAsBytes("&#xd;");
                         last = counter + 1;
                         break;
                     case '\t':

diff --git a/testcases/ooxml/XSSF/Streaming/SheetDataWriterTests.cs b/testcases/ooxml/XSSF/Streaming/SheetDataWriterTests.cs
@@ -333,7 +333,7 @@ public void IfCellTypeIsStringShouldWriteStringCellXml()
             var lines = File.ReadAllLines(_objectToTest.TemporaryFilePath());
 
             Assert.True(lines.Length == 1);
-            Assert.AreEqual("<c r=\"A1\" t=\"inlineStr\"><is><t xml:space=\"preserve\">\'\'&lt;&gt;&#x9;&#xa;&#xa;&amp;&quot;?         test:SLDFKj    </t></is></c>", lines[0]);
+            Assert.AreEqual("<c r=\"A1\" t=\"inlineStr\"><is><t xml:space=\"preserve\">\'\'&lt;&gt;&#x9;&#xa;&#xd;&amp;&quot;?         test:SLDFKj    </t></is></c>", lines[0]);
 
         }