Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omeka s version 3 support breaks functionality of ValueSuggest module #3

Closed
lklic opened this issue Mar 10, 2021 · 1 comment
Closed

omeka s version 3 support breaks functionality of ValueSuggest module #3

lklic opened this issue Mar 10, 2021 · 1 comment
Assignees
@nishad
Labels
bug Something isn't working
Milestone
v1.4.0

Comments

@lklic
Copy link

lklic commented Mar 10, 2021

adding this module breaks the functionality of the ValueSuggest module:https://github.com/omeka-s-modules/ValueSuggest

This is the case both if you have one field that uses multiple vocabs as well as a field that uses only one vocab from ValueSuggest.

If you deactivate the WikiData module the ValueSuggest module works again.

Can you please look into fixing this?

Thanks!
@nishad nishad self-assigned this Mar 16, 2021
@nishad nishad added the bug Something isn't working label Mar 16, 2021
@nishad nishad added this to the v1.4.0 milestone Mar 16, 2021
@Daniel-KM
Copy link

Fixed in #5.

@nishad nishad closed this as completed in ffb977c Dec 23, 2021
nishad added a commit that referenced this issue Dec 23, 2021
@nishad
Merge pull request #5 from Daniel-KM/fix/valuesuggest
7a1c65c 
Fixed compatibility with module Value Suggest (fix #3).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nishad nishad

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.4.0
Development

No branches or pull requests
3 participants
@nishad @Daniel-KM @lklic