FIX: Improve error handling of CommandLine interfaces
#3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, errors arising from interpolating the command line of these interfaces is handled poorly at the ``Node`` level. If the command line cannot be built, the error is printed in the logfile but the exception is caught and never raised (i.e., likely leading to an infinite loop as the execution is not stopped). I have experienced that while debugging fMRIPrep. To learn which of the inputs of a faulty interface derived from ``CommandLine`` was not being formatted, I had to also add the error annotation proposed for the ``_parse_inputs`` inner loop.
Codecov Report
@@ Coverage Diff @@
## master #3395 +/- ##
==========================================
+ Coverage 65.20% 65.29% +0.09%
==========================================
Files 307 307
Lines 40457 40926 +469
Branches 5350 5515 +165
==========================================
+ Hits 26379 26724 +345
- Misses 13003 13102 +99
- Partials 1075 1100 +25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
effigies
reviewed
Oct 22, 2021
effigies
approved these changes
Oct 22, 2021
|
Oh, looks like there's a style check failing... |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
added a commit
to effigies/niworkflows
that referenced
this pull request
Mar 9, 2022
effigies
added a commit
to effigies/niworkflows
that referenced
this pull request
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, errors arising from interpolating the command line of these interfaces is handled poorly at the
Nodelevel.If the command line cannot be built, the error is printed in the logfile but the exception is caught and never raised (i.e., likely leading to an infinite loop as the execution is not stopped).
I have experienced that while debugging fMRIPrep. To learn which of the inputs of a faulty interface derived from
CommandLinewas not being formatted, I had to also add the error annotation proposed for the_parse_inputsinner loop.Acknowledgment