Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the match_str_case_mismatch clippy check #378

Closed
jsdanielh opened this issue Oct 27, 2021 · 0 comments · Fixed by #401
Closed

Re-enable the match_str_case_mismatch clippy check #378

jsdanielh opened this issue Oct 27, 2021 · 0 comments · Fixed by #401
Assignees
@jsdanielh
Labels
enhancement New feature or request

Comments

@jsdanielh
Copy link
Member

On 0d60550 the clippy check match_str_case_mismatch was disabled for a match statement in lib/src/config/config_file/mod.rs.
It was introduced to avoid the issue documented here that was being flagged in the CI due to GH actions picking the latest nightly compiler and tools.
This issue is to remind to re-enable the check once a new nightly version is available with the fix.
@jsdanielh jsdanielh self-assigned this Oct 27, 2021
@jsdanielh jsdanielh added enhancement New feature or request P-low labels Nov 1, 2021
jsdanielh added a commit that referenced this issue Nov 5, 2021
@jsdanielh
Remove clippy workaround introduced
998b59a 
Remove clippy workaround introduced to avoid false positive checks
in the file `lib/src/config/config_file/mod.rs`. This can be
removed now since the issue that introduced it in clippy land is
already closed.
This closes #378.
@jsdanielh jsdanielh mentioned this issue Nov 5, 2021
Merged
2 tasks
viquezclaudio pushed a commit that referenced this issue Nov 5, 2021
@jsdanielh
Remove clippy workaround introduced (#401)
ec3d8cb 
Remove clippy workaround introduced to avoid false positive checks
in the file `lib/src/config/config_file/mod.rs`. This can be
removed now since the issue that introduced it in clippy land is
already closed.
This closes #378.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsdanielh jsdanielh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove clippy workaround introduced nimiq/core-rs-albatross
1 participant
@jsdanielh