region_infer: BitMatrix representation of region values #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
requested changes
Nov 22, 2017
|
|
||
| // Find every region `o` such that `fr: o` | ||
| // (because `fr` includes `end(o)`). | ||
| for &outlived_fr in &fr_value.free_regions { | ||
| for outlived_fr in fr_value.filter(|&i| i < self.num_free_regions) { |
There was a problem hiding this comment.
I think take_while would be better -- it would stop the loop sooner
| for &fr in &from_region.free_regions { | ||
| changed |= to_region.free_regions.insert(fr); | ||
| let free_region_indices = inferred_values.iter(from_region.index()) | ||
| .filter(|&i| i < self.num_free_regions).collect::<Vec<_>>(); |
There was a problem hiding this comment.
I think take_while would be more efficient
|
|
||
| /// The constraints we have accumulated and used during solving. | ||
| constraints: Vec<Constraint>, | ||
|
|
||
| /// A map from each MIR Location to its column index in | ||
| /// `liveness_constraints`/`inferred_values` | ||
| point_indices: BTreeMap<Location, usize>, |
There was a problem hiding this comment.
It'd be nice to expand this comment to explain that the first N indices are the free regions -- or at least comment on that somewhere.
|
Thanks @zackmdavis =) |
zackmdavis
force-pushed
the
nll_bitmatrix_region
branch
from
17dd78c
to
879feae
Compare
|
(force-push 879feae for |
nikomatsakis
force-pushed
the
nll-master
branch
from
1eadbfd
to
077c2a8
Compare
This should be more efficient than allocating two BTreeSets for every region variable?—as it is written in rust-lang#45670.
nikomatsakis
force-pushed
the
nll_bitmatrix_region
branch
from
879feae
to
466e135
Compare
|
Warning: rebased! |
|
And merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikomatsakis
This should be more efficient than allocating two BTreeSets for every region variable?—as it is written in rust-lang#45670.
This isn't addressing the question of auxillary methods for
BitMatrix. I'm also not immediately sure what kind of testing is appropriate.