Duplicate Dialog return value avoids mistakes reuse reference

[r888800009]

inochi-creator issue
Inochi2D/inochi-creator#392
Inochi2D/inochi-creator#378

Reproduce the crash

1. open inx
2. save as new inx
3. export png or video
4. waiting autosave

upstream pr: Inochi2D/inochi-creator#393

[seagetch]

I couldn't see entire part of the code now, but it seems duplicating every time in incProjectPath might be heavy operation if it is used in update loop of UI. if that happens, string duplication should be called at client side and only if it should be duplicated.

[r888800009]

It seems that this function is only called when file access, so encapsulates and protects the internal resources of incProjectPath.

Additionally, the issue appears to be caused by incShowSaveDialog() and incShowOpenDialog(), as they may be called in other places as well. I will apply a patch there too. that only called once when the user needs.

[seagetch]

I found incProjectPath is called in every update loop in incCheckAutosave.
So dup should not be called inside incProjectPath.

I still don't understand why this dup is needed yet.

[r888800009]

I think the root cause is that after users save as new .inx and export png or videos, they share the string returned by incShowSaveDialog()

leading to the two issues mentioned above.
The crash on macOS differ from those on Windows, windows is access denied, macos indicates that it is a directory.

[r888800009]

This will cause the user to overwrite the incProjectPath after exported the png.

[r888800009]

Maybe the d language cast is using the c_string memory address, I'm not sure

[r888800009]

This bug can also be reproduced like this

1. open inx
2. save as new inx
3. export png or video
4. Ctrl+s

You can see that the saved path is incorrect, but it will not crash.

[r888800009]

incCheckAutosave seems to be called per frame, that may need to be modified

[seagetch]

I couldn't reproduce this bug by myself. (MacOS)
I guess this is windows specific bug, with tinyfilefdialogs.

Or some sort of buffer overflow happens.
Anyway, first step seems to duplicate string which is passed as a input to tinyfiledialogs.

[r888800009]

@seagetch macos can be reproduced successfully, you may need to shorten the interval or set a hotkey invoke incAutosaveProject(incProjectPath);

std.file.FileException@std/file.d(840): /Users/user/Library/Application Support/nijigenerate/autosaves/未命名nx/nijigenerate-project.lock: Is a directory
----------------
??:? object.Throwable.TraceInfo core.runtime.defaultTraceHandler(void*) [0xxxxxxxxxx]
/Users/user/nijigenerate/source/nijigenerate/io/autosave.d:227 void nijigenerate.io.autosave.incCreateLockfile(immutable(char)[]) [0xxxxxxxxxx]
/Users/user/nijigenerate/source/nijigenerate/io/autosave.d:162 void nijigenerate.io.autosave.incAutosaveProject(immutable(char)[]) [0xxxxxxxxxx]
/Users/user/nijigenerate/source/nijigenerate/io/autosave.d:129 void nijigenerate.io.autosave.incCheckAutosave() [0xxxxxxxxxx]
/Users/user/nijigenerate/source/app.d:136 void app.incUpdate() [0xxxxxxxxxx]
/Users/user/nijigenerate/source/app.d:109 _Dmain [0xxxxxxxxxx]

In this case, I first "save as" and then export an "未命名" png. then call the autosave function

This bug can also be reproduced like this

1. open inx
2. save as new inx
3. export png or video
4. Ctrl+s
   You can see that the saved path is incorrect, but it will not crash. Make sure to use main branch

Make sure the two names are different The export name seems to need to be shorter than inx to reproduce

1. open "aka.inx"
2. save as "123456789" inx
3. add camera (Can be skipped)
4. export "123" png
5. wait auto save

std.file.FileException@std/file.d(840): /Users/user/Library/Application Support/nijigenerate/autosaves/1236789/nijigenerate-project.lock: Is a directory
----------------
??:? object.Throwable.TraceInfo core.runtime.defaultTraceHandler(void*) [0xxxxxxxxxx]
/Users/user/nijigenerate/source/nijigenerate/io/autosave.d:227 void nijigenerate.io.autosave.incCreateLockfile(immutable(char)[]) [0xxxxxxxxxx]
/Users/user/nijigenerate/source/nijigenerate/io/autosave.d:162 void nijigenerate.io.autosave.incAutosaveProject(immutable(char)[]) [0xxxxxxxxxx]
/Users/user/nijigenerate/source/nijigenerate/io/autosave.d:129 void nijigenerate.io.autosave.incCheckAutosave() [0xxxxxxxxxx]
/Users/user/nijigenerate/source/app.d:136 void app.incUpdate() [0xxxxxxxxxx]
/Users/user/nijigenerate/source/app.d:109 _Dmain [0xxxxxxxxxx]

[r888800009]

case 2

1. open "aka.inx"
2. save as "ABCDEFGHIJK" inx
3. export "1" png
4. wait auto save

std.file.FileException@std/file.d(840): /Users/user/Library/Application Support/nijigenerate/autosaves/1DEFGHIJK/nijigenerate-project.lock: Is a directory
----------------
??:? object.Throwable.TraceInfo core.runtime.defaultTraceHandler(void*) [0xxxxxxxxxx]
/Users/user/nijigenerate/source/nijigenerate/io/autosave.d:227 void nijigenerate.io.autosave.incCreateLockfile(immutable(char)[]) [0xxxxxxxxxx]
/Users/user/nijigenerate/source/nijigenerate/io/autosave.d:162 void nijigenerate.io.autosave.incAutosaveProject(immutable(char)[]) [0xxxxxxxxxx]
/Users/user/nijigenerate/source/nijigenerate/io/autosave.d:129 void nijigenerate.io.autosave.incCheckAutosave() [0xxxxxxxxxx]
/Users/user/nijigenerate/source/app.d:136 void app.incUpdate() [0xxxxxxxxxx]
/Users/user/nijigenerate/source/app.d:109 _Dmain [0xxxxxxxxxx]