-
Notifications
You must be signed in to change notification settings - Fork 71.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade APN Library & Support Time-Sensitive Notifications #8047
Upgrade APN Library & Support Time-Sensitive Notifications #8047
Conversation
I don't normally work with NPM (I'm an iOS dev) so would appreciate any pointers on this PR and practices for working with node packages. |
@@ -71,9 +71,9 @@ | |||
"dependencies": { | |||
"@babel/core": "^7.18.10", | |||
"@babel/preset-env": "^7.18.10", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added this package using the command:
npm install @parse/node-apn
I originally tried this from node version 18* but it added a bunch of changes to the file unrelated to my update (adding the prefix "node_modules" to each depedency). So I downgraded my node to an earlier version, v14.21.3, per some advice from SO and then ran the command again.
92386e5
to
d500fd8
Compare
"acorn": "^8.0.5", | ||
"acorn-jsx": "^5.3.1", | ||
"apn": "^2.2.0", | ||
"async": "^0.9.2", | ||
"babel-loader": "^8.2.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the original PR when the prior APN package was added, I see the "pem" and "base64url" libraries were added in the same PR. Those don't seem needed from what I can tell since upgrading the library. Below is the output of depcheck
right after I removed apn, which shows those as unused. So I've removed from now but let me know if there is something I'm missing.
depcheck
Unused dependencies
* acorn
* acorn-jsx
* base64url
* buffer
* crypto-browserify
* moment-locales-webpack-plugin
* pem
* process
* stream-browserify
* swagger-ui-dist
* webpack-cli
Unused devDependencies
* @types/tough-cookie
....
@@ -2045,11 +2039,6 @@ | |||
"supports-color": "^5.3.0" | |||
} | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Below here in the lock file, these updates seemed to implicitly happen from me removing the 3 libraries:
- apn
- base64url
- pem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks good, I will spend some time testing and integrating during my cycles, along with Nightscout Connect issues. Hopefully sometime this week. |
@bewest Thanks! |
Example of Loop push notifications being delivered as "time sensitive":