Fix default value of the checkbox in plugin-specific settings #8031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
OPENAPS_COLOR_PREDICTION_LINESis set totrue, the "Color prediction lines" checkbox in settings is incorrectly unchecked when opening Nightscout on a browser without any site data. This means that when you first change any settings, you'll override the current value of "Color prediction lines" to be false if you don't notice that the checkbox was unchecked despite the feature being enabled. This should fix that issue by using the proper setting value fromsettings.extendedSettingsrather than only checking the value in browser storage.There's actually one other problem that I noticed which I'm not sure what the best way to fix it is - "Reset, and use defaults" does not reset the plugin-specific settings. This happens because nothing in that link's on-click function touches
extendedSettings(settings.eachSetting()only lists direct attributes ofsettingsandsettings.thresholds).