Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7910 #7911

Merged
merged 2 commits into from
Feb 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions lib/api/entries/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -472,11 +472,6 @@ function configure (app, wares, ctx, env) {
});
} else {
inMemoryCollection = ctx.cache.getData('entries');

inMemoryCollection = _.sortBy(inMemoryCollection, function(item) {
const age = item.mills | item.date;
return age;
}).reverse();
}

if (inMemoryPossible && query.count <= inMemoryCollection.length) {
Expand Down
13 changes: 5 additions & 8 deletions lib/server/entries.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,11 @@ function storage (env, ctx) {

// Normalize dates to be in UTC, store offset in utcOffset

var _sysTime = moment(doc.dateString).isValid() ? moment.parseZone(doc.dateString) : moment(doc.date);
bewest marked this conversation as resolved.
Show resolved Hide resolved
_sysTime = _sysTime.isValid() ? _sysTime : moment();
var _sysTime;

if (doc.dateString) { _sysTime = moment.parseZone(doc.dateString); }
if (!_sysTime && doc.date) { _sysTime = moment(doc.date); }
if (!_sysTime) _sysTime = moment();

doc.utcOffset = _sysTime.utcOffset();
doc.sysTime = _sysTime.toISOString();
Expand Down Expand Up @@ -163,17 +166,11 @@ function storage (env, ctx) {
api.aggregate = require('./aggregate')({}, api);
api.indexedFields = [
'date'

, 'type'

, 'sgv'

, 'mbg'

, 'sysTime'

, 'dateString'

, { 'type': 1, 'date': -1, 'dateString': 1 }
];
return api;
Expand Down
54 changes: 48 additions & 6 deletions tests/api.entries.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@ var request = require('supertest');
var load = require('./fixtures/load');
var bootevent = require('../lib/server/bootevent');
var language = require('../lib/language')();
const _ = require('lodash');

require('should');

const FIVE_MINUTES=1000*60*5;

describe('Entries REST api', function ( ) {
var entries = require('../lib/api/entries/');
var self = this;
Expand All @@ -24,17 +28,38 @@ describe('Entries REST api', function ( ) {
bootevent(self.env, language).boot(function booted (ctx) {
self.app.use('/', entries(self.app, self.wares, ctx, self.env));
self.archive = require('../lib/server/entries')(self.env, ctx);

var creating = load('json');
creating.push({type: 'sgv', sgv: 100, date: Date.now()});
self.archive.create(creating, done);
self.ctx = ctx;
done();
});
});

beforeEach(function (done) {
var creating = load('json');
creating.push({type: 'sgv', sgv: 100, date: Date.now()});
self.archive.create(creating, done);

for (let i = 0; i < 20; i++) {
const e = {type: 'sgv', sgv: 100, date: Date.now()};
e.date = e.date - FIVE_MINUTES * i;
creating.push(e);
}

creating = _.sortBy(creating, function(item) {
return item.date;
});

function setupDone() {
console.log('Setup complete');
done();
}

function waitForASecond() {
// wait for event processing of cache entries to actually finish
setTimeout(function() {
setupDone();
}, 100);
}

self.archive.create(creating, waitForASecond);

});

afterEach(function (done) {
Expand Down Expand Up @@ -89,6 +114,23 @@ describe('Entries REST api', function ( ) {
});
});

it('gets entries in right order without type specifier', function (done) {
var defaultCount = 10;
request(self.app)
.get('/entries.json')
.expect(200)
.end(function (err, res) {
res.body.should.be.instanceof(Array).and.have.lengthOf(defaultCount);

var array = res.body;
var firstEntry = array[0];
var secondEntry = array[1];

firstEntry.date.should.be.above(secondEntry.date);

done( );
});
});

it('/echo/ api shows query', function (done) {
request(self.app)
Expand Down