respect per route body-parser configuration #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows each route to express policies for interpreting and parsing the request body. Before this change uploads to entries or treatments api would error if they were larger than 100Kb due to the preference being set for the whole server. This change removes the global preference in favor of allowing each route to choose it's own request size limit. We also refactor usage of body-parser to be more consistent throughout the code base. Most routes can use jsonParser, rawPraser, and urlencodedParser provided by the common wares component. Anything doing something else should be called out as such. For example, treatments, activity, and entries allow uploads up to 50Mb. Other v1 endpoints are using the common configuration set to 1Mb.
bewest
commented
Oct 13, 2021
Comment on lines
-29
to
-30
| app.use(bodyParser.json()); | ||
| app.use(bodyParser.urlencoded({ extended: true })); |
There was a problem hiding this comment.
These lines enforce a 100Kb limit for the entire server, regardless of per route configurations. Removing these lines allows the routes to properly express their size limit policies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows each route to express policies for interpreting and parsing
the request body. Before this change uploads to entries or treatments api
would error if they were larger than 100Kb due to the preference being set for
the whole server. This change removes the global preference in favor of
allowing each route to choose it's own request size limit.
We also refactor usage of body-parser to be more consistent throughout the code
base. Most routes can use jsonParser, rawPraser, and urlencodedParser provided
by the common wares component. Anything doing something else should be called
out as such. For example, treatments, activity, and entries allow uploads up
to 50Mb. Other v1 endpoints are using the common configuration set to 1Mb.