Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/2020 06 28/carelink #5725

Merged
merged 7 commits into from
Sep 13, 2020
Merged

Hotfix/2020 06 28/carelink #5725

merged 7 commits into from
Sep 13, 2020

Conversation

bewest
Copy link
Member

@bewest bewest commented Jun 29, 2020

Hotfix for master. Similar to #5721

@bewest
prepare hotfix for MMConnect/EU - 2020-06-28
1062a0d 
Prepare to handle issue #5719.  This patch adjusts dependencies to
target a community edition fork of minimed-connect-to-nightscout.  The
new dependency targets information provided to begin addressing
changes to Medtronic Carelink services starting late June 2020.
@bewest
bump pointing at right tag
bcd6df2
@danfarcas1972
Copy link

@FredMK made a great job. Is working.
We wait to merge it in cgm-remote-monitor/master

@bewest bewest mentioned this pull request Jun 30, 2020
Closed
@bewest
attempt 4 at hotfix for nightscout
93c8447 
Based on more reliable version of minimed-connect-to-nightscout....
This is testing the hotfix.  When it works, we will bump this one more
time with the newly released version.
@bewest
Copy link
Member Author

bewest commented Jul 1, 2020

nightscout/minimed-connect-to-nightscout#3 - this hotfix is currently targeting hotfix/2020-06-28-carelink, a branch with patches for hotfix and version bump on the module. Once known good version is tracked, we will version bump minimed-connect-nightscout and adjust this hotfix to match, and hotfix release.

@bewest
Copy link
Member Author

bewest commented Jul 2, 2020

This hotfix is now depending on an officially released version of minimed-connect-to-nightscout@1.4.0.

Process of accepting this pull request:

  • multiple reviewers sign off that it is working when deployed as expected, bonus points for US and EU folks.
  • Once confirmed, I'll run: ./prep_repo_release.sh patch; git checkout master ; git merge -; git push origin --tags master
  • Above should mark this pull request as closed. I'll also push the new release branch.

We don't publish on npm, so I think that's it, IIRC.

This was referenced Jul 2, 2020
Merged
Open
Closed
Merged
Closed
@bewest
Copy link
Member Author

bewest commented Jul 4, 2020

I need some confirmation if this is working or not in order to release hotfix back to master. At this point I want to get master fixed and then worry about dev. As far as I know, this fixes, it just needs confirmation and reviewer sign off.

@FredMK
Copy link

FredMK commented Jul 4, 2020

In my branch I released some changes, and tests for EU and US connection.

@Grynn
Copy link

Grynn commented Jul 5, 2020

need some confirmation if this is working or not in order to release hotfix back to master. At this point I want to get master fixed and then worry about dev. As far as I know, this fixes, it just needs confirmation and reviewer sign off.

FWIW, this branch has been working reliably for me from Jul 3, 4.30pm (GMT +5.3) ...
(Deployed on Heroku)

I did change env, by adding MMCONNECT_VERBOSE and changing MMCONNECT_INTERVAL to 30s from 60s (but that should not have hurt anything).

@marchugelshofer1981
Copy link

Hi bewest
I just got this update (hotfix/2020-06-28-carelink branch) and finally everything is working again for me.

sulkaharo
sulkaharo approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@sulkaharo sulkaharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sulkaharo sulkaharo merged commit 46e3d8f into master Sep 13, 2020
@sulkaharo sulkaharo deleted the hotfix/2020-06-28/carelink branch September 14, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulkaharo sulkaharo sulkaharo approved these changes

@shanselman shanselman Awaiting requested review from shanselman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bewest @danfarcas1972 @FredMK @Grynn @marchugelshofer1981 @sulkaharo