Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes in one PR #4253

Merged
merged 11 commits into from
Feb 3, 2019
Merged

Various fixes in one PR #4253

merged 11 commits into from
Feb 3, 2019

Commits on Feb 2, 2019

  1. make Saving profile translatable

    @PieterGit
    PieterGit committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    04ec3ab View commit details
    Browse the repository at this point in the history

  2. fix readENVTruthy and make INSECURE_USE_HTTP, SECURE_HSTS_HEADER, SEC… 

    …URE_HSTS_HEADER_* and SECURE_CSP work as expected.

readENVTruthy never returned defaultValue. if not set to on|off|true|false the default value is returned
    @PieterGit
    PieterGit committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    3104083 View commit details
    Browse the repository at this point in the history

  3. npm update

    @PieterGit
    PieterGit committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    0b7fe94 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' of https://github.com/nightscout/cgm-remote-monitor … 

    …into 201901_profile_save_workaround2
    @PieterGit
    PieterGit committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    05d47f8 View commit details
    Browse the repository at this point in the history

  5. add missing env

    @PieterGit
    PieterGit committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    6432298 View commit details
    Browse the repository at this point in the history

  6. upgrade to minmum of Node 10.15.1

    @PieterGit
    PieterGit committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    8098cda View commit details
    Browse the repository at this point in the history

  7. fix ident and add extra test to env.test.js

    @PieterGit
    PieterGit committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    a6b98c3 View commit details
    Browse the repository at this point in the history

  8. remove mqtt leftover

    @PieterGit
    PieterGit committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    9c5a2e4 View commit details
    Browse the repository at this point in the history

  9. ie8 is not compatible with Terser, so make that explicit

    @PieterGit
    PieterGit committed Feb 2, 2019
    Configuration menu
    Copy the full SHA
    cabace2 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2019

  1. npm update and integrate terser-webpack-plugin as minimizer 

    Stick to `terser` version `~3.14.1` instead of `^3.16.0`, because of
```
ERROR in js/bundle.js from Terser
TypeError: Cannot read property 'minify' of undefined
    at minify (E:\path\toc\cgm-remote-monitor\node_modules\terser-webpack-plugin\dist\minify.js:175:23)
```

See terser/terser#254 for details on that bug
    @PieterGit
    PieterGit committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    d97fd97 View commit details
    Browse the repository at this point in the history

  2. user correct env

    @PieterGit
    PieterGit committed Feb 3, 2019
    Configuration menu
    Copy the full SHA
    ab54f09 View commit details
    Browse the repository at this point in the history