Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CGM voltageb battery warning level to match xDrip+ #3954

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Fix CGM voltageb battery warning level to match xDrip+ #3954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/plugins/xdrip-js.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ function init(ctx) {
result.level = levels.WARN;
}

if (sensorInfo.xdripjs.voltageb && (sensorInfo.xdripjs.voltageb < prefs.warnBatV)) {
if (sensorInfo.xdripjs.voltageb && (sensorInfo.xdripjs.voltageb < (prefs.warnBatV - 10))) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the prefs.warnBatV not be lowered by 10 then?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

voltagea test uses the prefs.warnBatV value as is (not shown in the snippet above), but voltageb is offset to 10 less than the voltagea test value.

sendNotification = true;
message = 'CGM Battery B Low Voltage: ' + sensorInfo.xdripjs.voltageb;
title = 'CGM Battery Low';
Expand Down