Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Basal Icicle mode; store basal mode in localstorage #1261

Merged
merged 8 commits into from
Oct 28, 2015

Conversation

jasoncalabrese
Copy link
Member

Instead of a select or checkbox we did this:

screen shot 2015-10-27 at 7 45 28 pm

@codecov-io
Copy link

Current coverage is 84.49%

Merging #1261 into dev will increase coverage by +0.10% as of 50e4a26

@@              dev   #1261   diff @@
=====================================
  Files          79      79       
  Stmts        6096    6096       
  Branches        0       0       
  Methods         0       0       
=====================================
+ Hit          5145    5151     +6
  Partial         0       0       
+ Missed        951     945     -6

Review entire Coverage Diff as of 50e4a26


Uncovered Suggestions

  1. +0.20% via .../js/profileeditor.js#324...335
  2. +0.18% via .../js/profileeditor.js#269...279
  3. +0.17% via .../report/js/report.js#259...268
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@bewest
Copy link
Member

bewest commented Oct 26, 2015

There's some regression in dev (before this patch) but before 5dc49692432229892613fb022c9aa176eb62f5ff in wip/increase-upload-limit which is preventing temp basals from being displayed.

@bewest
Copy link
Member

bewest commented Oct 26, 2015

Comments are that on laptop/desktop the selector is extremely small. Otherwise it's pretty awesome to have multiple choices here.

@jasoncalabrese
Copy link
Member Author

Think we need to open a panel instead of trying to use a select for this, maybe something simple like we do for snoozing alarms.

@bewest
Copy link
Member

bewest commented Oct 28, 2015

image

@bewest
Copy link
Member

bewest commented Oct 28, 2015

Looks great:
image

Working great:
image

@bewest
Copy link
Member

bewest commented Oct 28, 2015

Err, here's one with the right screenshot:

image

jasoncalabrese added a commit that referenced this pull request Oct 28, 2015
Added Basal Icicle mode; store basal mode in localstorage
@jasoncalabrese jasoncalabrese merged commit 9653ebf into dev Oct 28, 2015
@jasoncalabrese jasoncalabrese deleted the wip/icicle branch October 28, 2015 22:50
@jasoncalabrese jasoncalabrese modified the milestone: 0.8.2 Oct 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants