Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now line is 10 minutes in the future. #27

Closed
Dexcgm opened this issue Jun 30, 2014 · 12 comments
Closed

Now line is 10 minutes in the future. #27

Dexcgm opened this issue Jun 30, 2014 · 12 comments

Comments

@Dexcgm
Copy link

Dexcgm commented Jun 30, 2014

Now line is showing 10 minutes in the future. Blue dots are also appearing flat and not sloping correctly. This is all since I editing code to make it mmol in Master

https://github.com/Dexcgm/cgm-remote-monitor.git
Any help would be greatly appreciated.

@jasoncalabrese
Copy link
Member

I was expecting to only see changes to client.js try reverting those and see if it works. We should be able to do the conversion client side only.

@Dexcgm
Copy link
Author

Dexcgm commented Jun 30, 2014

I reverted client.js to the same code in the nightscout client.js but can't tell if that solved the issue because none of the data points show up (since the scale is then wrong).

@jasoncalabrese
Copy link
Member

I thought client.js might have been right, but server.js might need to be reverted.

@rnpenguin
Copy link
Contributor

They both need changes.

In the client, the scaling should be updated and the predictAR function. Looks like the client has been updated.

In the server, sgv is used for alarms, loss function calculation, and prediction. This should be updated as well.

@Dexcgm
Copy link
Author

Dexcgm commented Jun 30, 2014

I have tried reverting both, but both do require the edits in order for mmol to work correctly... Blue dots are now sloping correctly. Just need now line to be correct.

@Dexcgm
Copy link
Author

Dexcgm commented Jul 3, 2014

Still haven't been able to figure what I have done wrong... If you could help that would be great so that I can share my version with those who want to use the mmol version. I really appreciate any help I can get here...

@rnpenguin
Copy link
Contributor

Sure. I'm guessing your dB records are in mmol?

@jasoncalabrese
Copy link
Member

I thought db was going to stay mg/dl and the conversion to mmol was going to be done UI only

@rnpenguin
Copy link
Contributor

That would be best, just wondering which units his dB records are in cause I would guess the uploaded uploads which ever units they are in

@rnpenguin
Copy link
Contributor

@ELUTE
Copy link
Contributor

ELUTE commented Jul 3, 2014

db records are in mg/dl I will take a look at the above branch, it will not allow me to test deployment for some reason.

@ELUTE
Copy link
Contributor

ELUTE commented Jul 3, 2014

WORKS BEAUTIFULLY!!! THANK YOU!!!!

@Dexcgm Dexcgm closed this as completed Jul 5, 2014
brianhanifin added a commit that referenced this issue Jul 23, 2014
PieterGit pushed a commit to PieterGit/cgm-remote-monitor that referenced this issue Jan 20, 2019
cominixo pushed a commit to cominixo/cgm-remote-monitor that referenced this issue Mar 1, 2021
Adds details on adding a custom domain name to your heroku app
mrspouse pushed a commit to mrspouse/cgm-remote-monitor that referenced this issue Apr 3, 2022
freddyyi pushed a commit to freddyyi/cgm-remote-monitor that referenced this issue Apr 22, 2022
tzachi-dar referenced this issue in tzachi-dar/nightscout-vps Nov 14, 2022
aiwaz pushed a commit to aiwaz/cgm-remote-monitor that referenced this issue Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants