Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up NFR test result formatting #2505

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Clean up NFR test result formatting #2505

merged 1 commit into from
Sep 3, 2024

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Sep 3, 2024

Problem: Some results files added extra newlines, causing our formatter to fail. Also, error log files were way too large for feasible parsing.

Solution: Remove extra newlines, and only include error logs instead of full log files.

@sjberman sjberman requested a review from a team as a code owner September 3, 2024 19:44
@github-actions github-actions bot added the tests Pull requests that update tests label Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (81d4142) to head (81eef15).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2505   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         100      100           
  Lines        7539     7539           
  Branches       50       50           
=======================================
  Hits         6726     6726           
  Misses        756      756           
  Partials       57       57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Problem: Some results files added extra newlines, causing our formatter to fail. Also, error log files were way too large for feasible parsing.

Solution: Remove extra newlines, and only include error logs instead of full log files.
@sjberman sjberman merged commit ef7a852 into main Sep 3, 2024
41 checks passed
@sjberman sjberman deleted the tests/nfr-format branch September 3, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants