Data Documentation for load_espn_qbr #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! You can check locally to see if the pkgdown will build by running |
tanho63
reviewed
Dec 31, 2021
|
Can you also run |
tanho63
requested changes
Dec 31, 2021
|
thanks for getting back! might be a dumb question, but where should I run devtools::document()? |
|
Just in your console, it'll operate over the whole package |
auto-merge was automatically disabled
December 31, 2021 16:32
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys,
I thought I'd try and give back to the nflreadr because of how helpful it is, so I started to work on one of the "good first issues" that were listed. To start, I created a data dictionary for the "load_espn_qbr" package which is what this pull request is for. Everything seems to work fine on my end in R (if I load in my forked github using devtools), but I'm not sure on how to test if my updates are also shown in the pkgdown website.
Please let me know if I did anything wrong, and any feedback would be much appreciated. Thanks for all you do for the community!