Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Multiple DOIs from manifest #2946

Merged
merged 6 commits into from
May 3, 2024
Merged

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@maxulysse maxulysse changed the base branch from master to dev May 2, 2024 09:53
@nf-core nf-core deleted a comment from github-actions bot May 2, 2024
@maxulysse
Copy link
Member Author

maxulysse commented May 2, 2024

@maxulysse maxulysse changed the title Handle Multiple doi from manifest Handle Multiple DOIs from manifest May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.38%. Comparing base (0adbe37) to head (13e5170).
Report is 1 commits behind head on dev.

❗ Current head 13e5170 differs from pull request most recent head 0a9746a. Consider uploading reports for the commit 0a9746a to get more accurate results

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, don't forget to update the CHANGELOG.md 🙂

@maxulysse
Copy link
Member Author

LGTM, don't forget to update the CHANGELOG.md 🙂

Need to had another fix in

@mashehu
Copy link
Contributor

mashehu commented May 3, 2024

Fix for CI tests is in #2949

@maxulysse
Copy link
Member Author

So I actually did some check in the MultiQC report, checkin the riboseq pipeline.
The text says:
-> doi: https://doi.org/10.5281/zenodo.10966364, which links to https://doi.org/https://doi.org/10.5281/zenodo.10966364, which actually resolves nicely into https://doi.org/10.5281/zenodo.10966364.
But the text should really be saying doi: 10.5281/zenodo.10966364 and link to https://doi.org/10.5281/zenodo.10966364, which this PR is now doing

@maxulysse maxulysse merged commit 34cde0c into nf-core:dev May 3, 2024
34 checks passed
@maxulysse maxulysse deleted the multiple_DOI branch May 3, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants