Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: lint nextflow.config default values match the ones specified in nextflow_schema.json #2684

Merged
merged 4 commits into from
Jan 26, 2024
Merged

Linting: lint nextflow.config default values match the ones specified in nextflow_schema.json #2684

merged 4 commits into from
Jan 26, 2024

Conversation

mirpedrol
Copy link
Member

Close #1954

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

mashehu
mashehu approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice tests!

nf_core/lint/nextflow_config.py Outdated Show resolved Hide resolved
tests/lint/nextflow_config.py Outdated Show resolved Hide resolved
tests/lint/nextflow_config.py Outdated Show resolved Hide resolved
nf_core/lint/nextflow_config.py Outdated Show resolved Hide resolved
@mirpedrol @mashehu
Apply suggestions from code review
57bc258 
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@mirpedrol mirpedrol merged commit 86ffafe into nf-core:dev Jan 26, 2024
36 checks passed
@mirpedrol mirpedrol deleted the lint-config-schema branch January 26, 2024 15:15
@mirpedrol mirpedrol mentioned this pull request Jan 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirpedrol @mashehu @nf-core-bot