Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dodgy sniffer code from samplesheet_check.py #2194

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Feb 24, 2023

See nf-core/funcscan#227 for more info

Closes #1539

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #2194 (6de786c) into dev (7f30502) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #2194   +/-   ##
=======================================
  Coverage   71.57%   71.57%           
=======================================
  Files          77       77           
  Lines        8369     8369           
=======================================
  Hits         5990     5990           
  Misses       2379     2379           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@edmundmiller edmundmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Maybe add a TODO to check for a header?

@jfy133
Copy link
Member Author

jfy133 commented Feb 26, 2023

Love it! Maybe add a TODO to check for a header?

I think @Midnighter said we actually already check for this when checking for the actual expected header string

@Midnighter
Copy link
Contributor

Love it! Maybe add a TODO to check for a header?

I think @Midnighter said we actually already check for this when checking for the actual expected header string

Indeed! Check lines 194-202.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants