Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle json.load() exceptions #2134

Merged
merged 11 commits into from
Dec 17, 2022
Merged

Conversation

mirpedrol
Copy link
Member

@mirpedrol mirpedrol commented Dec 16, 2022

Close #2126

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@github-actions
Copy link
Contributor

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @mirpedrol,

It looks like this pull-request is has been made against the mirpedrol/tools master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the mirpedrol/tools dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@mirpedrol mirpedrol changed the base branch from master to dev December 16, 2022 08:54
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #2134 (632b675) into dev (ee6725a) will decrease coverage by 0.04%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##              dev    #2134      +/-   ##
==========================================
- Coverage   71.47%   71.43%   -0.05%     
==========================================
  Files          77       77              
  Lines        8358     8367       +9     
==========================================
+ Hits         5974     5977       +3     
- Misses       2384     2390       +6     
Impacted Files Coverage Δ
nf_core/lint/nextflow_config.py 77.45% <ø> (ø)
nf_core/modules/modules_json.py 80.26% <50.00%> (-0.28%) ⬇️
nf_core/utils.py 82.38% <50.00%> (-0.28%) ⬇️
nf_core/schema.py 76.12% <100.00%> (+0.14%) ⬆️
nf_core/modules/lint/module_version.py 78.26% <0.00%> (-4.35%) ⬇️
nf_core/modules/lint/__init__.py 82.72% <0.00%> (-0.53%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirpedrol mirpedrol merged commit d45b8e3 into nf-core:dev Dec 17, 2022
@mirpedrol mirpedrol deleted the handle-json-exception branch December 17, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled exception when parsing config
2 participants