Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run prettier after dumping a json schema file #2124

Merged
merged 5 commits into from
Dec 15, 2022

Conversation

mirpedrol
Copy link
Member

Close #2115

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Dec 12, 2022

Codecov Report

Merging #2124 (6eb4664) into dev (e178898) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #2124      +/-   ##
==========================================
+ Coverage   71.39%   71.47%   +0.08%     
==========================================
  Files          77       77              
  Lines        8358     8358              
==========================================
+ Hits         5967     5974       +7     
+ Misses       2391     2384       -7     
Impacted Files Coverage Δ
nf_core/launch.py 63.26% <100.00%> (-0.10%) ⬇️
nf_core/lint_utils.py 80.76% <100.00%> (+2.04%) ⬆️
nf_core/modules/modules_json.py 80.53% <100.00%> (-0.12%) ⬇️
nf_core/schema.py 75.98% <100.00%> (-0.05%) ⬇️
nf_core/components/update.py 81.51% <0.00%> (ø)
nf_core/modules/test_yml_builder.py 52.00% <0.00%> (+0.88%) ⬆️
nf_core/modules/modules_differ.py 92.46% <0.00%> (+2.51%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

nf_core/launch.py Outdated Show resolved Hide resolved
@ewels ewels linked an issue Dec 13, 2022 that may be closed by this pull request
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth putting these into a helper function that takes an object and a filename and writes + runs prettier..?

Otherwise happy to merge 👍🏻

nf_core/launch.py Outdated Show resolved Hide resolved
nf_core/schema.py Outdated Show resolved Hide resolved
@mirpedrol mirpedrol merged commit 10b2b7f into nf-core:dev Dec 15, 2022
@mirpedrol mirpedrol deleted the prettier-json-schema branch December 15, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

schema doesn't run prettier after build
4 participants