Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure component author is properly captured and stored #2120

Merged
merged 1 commit into from
Dec 9, 2022

Conversation

awgymer
Copy link
Contributor

@awgymer awgymer commented Dec 9, 2022

Fixes #2119

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@awgymer awgymer linked an issue Dec 9, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #2120 (0d7925b) into dev (67e3702) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #2120   +/-   ##
=======================================
  Coverage   71.43%   71.44%           
=======================================
  Files          77       77           
  Lines        8350     8351    +1     
=======================================
+ Hits         5965     5966    +1     
  Misses       2385     2385           
Impacted Files Coverage Δ
nf_core/components/components_create.py 75.00% <100.00%> (+0.23%) ⬆️
nf_core/modules/create.py 84.95% <100.00%> (ø)
nf_core/subworkflows/create.py 95.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mashehu mashehu added this to the 2.7.2 milestone Dec 9, 2022
@mashehu
Copy link
Contributor

mashehu commented Dec 9, 2022

weird one

@mashehu
Copy link
Contributor

mashehu commented Dec 9, 2022

Should we write a test for this?

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! 😄

I suspect this was a mistake introduced when creating components_create.py which doesn't have the object to call to self.author.

@awgymer awgymer merged commit 3dc4052 into nf-core:dev Dec 9, 2022
@awgymer awgymer deleted the fix-component-author branch December 9, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module authors not being added to meta yml
3 participants