Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use packaging instead of deprecated distutils Version classes #1735

Merged
merged 3 commits into from
Aug 9, 2022

Conversation

fabianegli
Copy link
Contributor

@fabianegli fabianegli commented Aug 5, 2022

distutils Version classes are deprecated in favor of the ones in packaging.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #1735 (b2b967e) into dev (a9d0665) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1735      +/-   ##
==========================================
+ Coverage   68.29%   68.45%   +0.15%     
==========================================
  Files          59       59              
  Lines        7063     7136      +73     
==========================================
+ Hits         4824     4885      +61     
- Misses       2239     2251      +12     
Impacted Files Coverage Δ
nf_core/utils.py 80.97% <100.00%> (-0.13%) ⬇️
nf_core/modules/modules_command.py 83.78% <0.00%> (-4.03%) ⬇️
nf_core/lint/modules_json.py 76.66% <0.00%> (-3.34%) ⬇️
nf_core/modules/update.py 75.64% <0.00%> (-2.81%) ⬇️
nf_core/modules/lint/module_changes.py 50.00% <0.00%> (-2.39%) ⬇️
nf_core/modules/lint/module_patch.py 10.66% <0.00%> (-2.33%) ⬇️
nf_core/modules/module_test.py 53.33% <0.00%> (-1.47%) ⬇️
nf_core/modules/patch.py 80.70% <0.00%> (-0.78%) ⬇️
nf_core/modules/lint/module_version.py 82.60% <0.00%> (-0.73%) ⬇️
nf_core/modules/lint/__init__.py 82.47% <0.00%> (-0.51%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

CHANGELOG.md Outdated Show resolved Hide resolved
@mashehu mashehu merged commit c65b8da into nf-core:dev Aug 9, 2022
@fabianegli fabianegli deleted the use-packaging branch August 16, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants