Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the TODO comment in a YAML array. #1089

Merged
merged 4 commits into from
May 20, 2021
Merged

Conversation

charles-plessy
Copy link
Contributor

The contains: map needs an array of strings. By placing the TODO comment between brackets I hope that the user will be more likely to produce a valid file.

Closes: #1082

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

charles-plessy and others added 3 commits May 19, 2021 09:39
The `contains:` map needs an array of strings.  By placing the TODO comment between brackets I hope that the user will be more likely to produce a valid file. 

Closes: nf-core#1082
@KevinMenden
Copy link
Contributor

Thanks @charles-plessy ! Looks good to me ... it's only failing because of those annoying module lint tests. Really should go about improving them somehow 🤔

@KevinMenden
Copy link
Contributor

@charles-plessy if you could pull the most recent changes from dev into your branch, then those tests should be fixed.

@charles-plessy
Copy link
Contributor Author

@KevinMenden sorry that I used the master branch instead of dev. I see that you already made a merge; do I have to do something else?

@KevinMenden
Copy link
Contributor

You would need to merge the most recent changes from nf-core/tools:dev into your current path-1 branch, this will fix the tests.

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #1089 (c846074) into dev (cb9b626) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1089   +/-   ##
=======================================
  Coverage   72.24%   72.24%           
=======================================
  Files          36       36           
  Lines        4547     4547           
=======================================
  Hits         3285     3285           
  Misses       1262     1262           
Impacted Files Coverage Δ
nf_core/modules/test_yml_builder.py 45.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9b626...c846074. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants