Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump nf-schema to v2.1.1 in the template #3177

Merged
merged 2 commits into from
Sep 20, 2024
Merged

bump nf-schema to v2.1.1 in the template #3177

merged 2 commits into from
Sep 20, 2024

Conversation

nvnieuwk
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

mirpedrol
mirpedrol approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the bug with defaultIgnoreParams solved in 2.1.1?

@nvnieuwk
Copy link
Contributor Author

Yes it is! and some other small fixes that were detected

@mirpedrol
Copy link
Member

Nice! Thanks for removing the params. Ok for me to merge. I re-run the tests, they should all pass now

@nvnieuwk
Copy link
Contributor Author

One is still failing but it doesn't look like it's related to this PR (ontology linting) so I'll go ahead and merge :)

@nvnieuwk nvnieuwk merged commit 9e05574 into dev Sep 20, 2024
82 of 83 checks passed
@nvnieuwk nvnieuwk deleted the nvnieuwk-patch-1 branch September 20, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @mirpedrol