Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

White on white can be hard to read #1045

Closed
pontus opened this issue Apr 30, 2021 · 4 comments · Fixed by #1027
Closed

White on white can be hard to read #1045

pontus opened this issue Apr 30, 2021 · 4 comments · Fixed by #1027
Labels
bug Something isn't working
Milestone
1.14

Comments

@pontus
Copy link
Contributor

pontus commented Apr 30, 2021

Description of the bug

Some texts are hard to read on white/light background.

wow

Steps to reproduce

  1. Set a light terminal background
  2. Run nf-core with some prompt using white.

Expected behaviour

All texts should be readable.

System

  • Version of nf-core/tools: master
  • Python version: 3.9.4
@pontus pontus added the bug Something isn't working label Apr 30, 2021
@ewels
Copy link
Member

ewels commented Apr 30, 2021

Specifically in #1027 (not yet merged)

@pontus
Copy link
Contributor Author

pontus commented Apr 30, 2021

(This seems to be caused by the style white bold, which seems to occur 8 times in master as well.)

@ewels
Copy link
Member

ewels commented Apr 30, 2021

Ah ok, I'll look into it, thanks 👍🏻

ewels added a commit to ErikDanielsson/tools that referenced this issue Apr 30, 2021
@ewels
Just bold, not white on bold.
3d0d415 
See nf-core#1045
ewels added a commit to ErikDanielsson/tools that referenced this issue Apr 30, 2021
@ewels
Removed more white bold, replaced with bold.
10ddb01 
Better on white colour scheme terminals.

Fixes nf-core#1045
@ewels
Copy link
Member

ewels commented Apr 30, 2021

All occurences of white bold replaced with just bold in the codebase in #1027

In my dark theme this has no effect on the output, but in a light colour scheme it means that you can actually read the text 🔍 👀

Thanks for reporting @pontus ! Shout if you spot any other stuff like this after the merge 👍🏻

@ewels ewels linked a pull request Apr 30, 2021 that will close this issue
Interactive prompts for 'download' and 'launch' #1027
Merged
4 tasks
@ewels ewels added this to the 1.14 milestone May 9, 2021
@ewels ewels closed this as completed May 10, 2021
jenmuell added a commit to jenmuell/tools that referenced this issue Oct 11, 2022
@jenmuell
update of parameter schema section nf-core#1045
5633757 
nf-core#1045
- update on the pipeline schema documentation for updates and changes
- added a paragraph for `nextflow schema docs`
mirpedrol added a commit that referenced this issue Nov 2, 2022
@mirpedrol
Merge pull request #1926 from jenmuell/update_to_pipeline_schema_doc
9c1472e 
Update to pipeline schema doc #1045
@jenmuell jenmuell mentioned this issue Mar 28, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.14
Development

Successfully merging a pull request may close this issue.

Interactive prompts for 'download' and 'launch' ErikDanielsson/tools
2 participants
@pontus @ewels