Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version for patch release #427

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Bump version for patch release #427

merged 7 commits into from
Jan 12, 2024

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jan 12, 2024 •
edited
Loading

Also fixes a mistake a noticed in the reporting of the preprint in the methods section of MQC

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/taxprofiler branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 mentioned this pull request Jan 12, 2024
Merged
10 tasks
jfy133
jfy133 commented Jan 12, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 12, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8959ae7

+| ✅ 163 tests passed       |+
!| ❗   1 tests had warnings |!

❗ Test warnings:

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-12 07:43:33

jfy133
jfy133 commented Jan 12, 2024
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
LilyAnderssonLee
LilyAnderssonLee approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@LilyAnderssonLee LilyAnderssonLee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! You can merge after all tests have passed.

CHANGELOG.md Outdated Show resolved Hide resolved
@jfy133 @LilyAnderssonLee
Update CHANGELOG.md
8959ae7 
Co-authored-by: Lili Andersson-Li <64467552+LilyAnderssonLee@users.noreply.github.com>
@jfy133 jfy133 merged commit 2fc3c02 into dev Jan 12, 2024
26 checks passed
@jfy133 jfy133 deleted the patch-release-dump branch January 12, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyAnderssonLee LilyAnderssonLee LilyAnderssonLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @LilyAnderssonLee