Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 3.1.2 #906

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Release 3.1.2 #906

merged 1 commit into from
Jan 5, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen
Copy link
Contributor

looks fine but everything fails

@github-actions
Copy link

github-actions bot commented Jan 5, 2023 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit bfd426e

+| ✅ 142 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   3 tests had warnings |!
-| ❌   8 tests failed       |-

❌ Test failures:

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: '3.1.2'
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • schema_description - No description provided in schema for parameter: cnvkit_reference

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-01-05 15:37:45

@maxulysse
Copy link
Member Author

nf-core lint fails, but that's due to a tools release.
I'd really like to keep this patch as minimal as possible for benchmarking purpose, so, I won't include the fix for those

@maxulysse maxulysse mentioned this pull request Jan 5, 2023
Closed
9 tasks
@maxulysse
Copy link
Member Author

All tests that should succeed are successful.

@maxulysse maxulysse merged commit c87f4eb into nf-core:master Jan 5, 2023
@maxulysse maxulysse mentioned this pull request Jan 16, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @FriederikeHanssen