Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Md cram update #855

Merged
merged 7 commits into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,24 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [dev]

### Added

### Changed

- [#855](https://github.com/nf-core/sarek/pull/855) - Speed up duplicate marking by using `samtools` for CRAM conversion

### Fixed

- [#851](https://github.com/nf-core/sarek/pull/851) - Fix `schema` definition `None` for `cf_chrom_len`

### Deprecated

### Removed

### Dependencies

## [3.1](https://github.com/nf-core/sarek/releases/tag/3.1) - Rapaätno

Rapaätno is the river you can see from the Skierfe mountain.
Expand Down
2 changes: 1 addition & 1 deletion conf/modules/markduplicates.config
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ process {
}

withName: 'GATK4_MARKDUPLICATES' {
ext.args = '-REMOVE_DUPLICATES false -VALIDATION_STRINGENCY LENIENT --CREATE_INDEX true'
ext.args = '-REMOVE_DUPLICATES false -VALIDATION_STRINGENCY LENIENT'
ext.prefix = { "${meta.id}.md.cram" }
ext.when = { !(params.skip_tools && params.skip_tools.split(',').contains('markduplicates')) }
publishDir = [
Expand Down
3 changes: 2 additions & 1 deletion modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,8 @@
},
"gatk4/markduplicates": {
"branch": "master",
"git_sha": "7578005a576f3ac1b0d4f10c037dde34cdedfb67"
"git_sha": "7578005a576f3ac1b0d4f10c037dde34cdedfb67",
"patch": "modules/nf-core/gatk4/markduplicates/gatk4-markduplicates.diff"
},
"gatk4/markduplicatesspark": {
"branch": "master",
Expand Down
45 changes: 45 additions & 0 deletions modules/nf-core/gatk4/markduplicates/gatk4-markduplicates.diff

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions modules/nf-core/gatk4/markduplicates/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.