Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mini-fix of split fastq names in multiqc report #658

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Mini-fix of split fastq names in multiqc report #658

merged 2 commits into from
Jul 19, 2022

Conversation

SusiJo
Copy link
Contributor

@SusiJo SusiJo commented Jul 19, 2022

PR checklist

Mini-fix of split fastq names in multiqc report

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@SusiJo
Copy link
Contributor Author

SusiJo commented Jul 19, 2022

Do not merge yet. Waiting if anything else needs to be changed concerning the names appearing under section GATK4 MarkDuplicates in the multiqc_report.html

@github-actions
Copy link

github-actions bot commented Jul 19, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 3c51b13

+| ✅ 146 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • readme - README did not have a Nextflow minimum version badge.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-sarek_logo_dark.png
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.4.1
  • Run at 2022-07-19 10:16:45

@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review July 19, 2022 12:06
@FriederikeHanssen FriederikeHanssen merged commit 35d2911 into nf-core:dev Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SusiJo @maxulysse @FriederikeHanssen