Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with wholegenome.interval_list file #58

Merged
merged 3 commits into from
Nov 4, 2019

Conversation

maxulysse
Copy link
Member

@klmr

Many thanks to contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: guidelines

@maxulysse maxulysse added the bug Something isn't working label Oct 30, 2019
@maxulysse maxulysse self-assigned this Oct 30, 2019
@maxulysse maxulysse requested a review from a team October 30, 2019 14:47
@drpatelh
Copy link
Member

drpatelh commented Nov 4, 2019

@maxulysse GATK includes a number of tools for interval manipulation and conversion. Are these not suited to what you are trying to do?
https://software.broadinstitute.org/gatk/documentation/tooldocs/current/org_broadinstitute_hellbender_tools_walkers_SplitIntervals.php

@maxulysse
Copy link
Member Author

Not really, we designed our intervals file based on the one provided by the broad, but we added some extra infos to group up some intervals.
But I'm willing to have a look into GATK specific intervals tools in some refactoring for a future PR

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Looks good to me too in that case 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants