Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release #37

Merged
merged 11 commits into from
Sep 20, 2019
Merged

Prepare release #37

merged 11 commits into from
Sep 20, 2019

Conversation

maxulysse
Copy link
Member

  • nf-core bump-version . 2.5

Many thanks to contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse self-assigned this Sep 18, 2019
@maxulysse maxulysse requested review from a team and removed request for a team September 18, 2019 14:00
Copy link
Contributor

@szilvajuhos szilvajuhos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you get these names from?

@maxulysse
Copy link
Member Author

I'm still following the list of peaks:
https://en.wikipedia.org/wiki/Sarek_National_Park#Topography
Once it's over, I was planning to go with lakes or rivers.

@maxulysse
Copy link
Member Author

maxulysse commented Sep 18, 2019

I need to update the date in the CHANGELOG on this one, so I'll merge it myself when I'll be ready for the release.

EDIT: Actually, I don't need the date... So I'll be merging this one soon

@maxulysse maxulysse mentioned this pull request Sep 18, 2019
5 tasks
CHANGELOG.md Outdated Show resolved Hide resolved
@maxulysse maxulysse merged commit 24e4601 into nf-core:dev Sep 20, 2019
@maxulysse maxulysse deleted the Release branch September 20, 2019 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants