Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Lint #33

Merged
merged 6 commits into from
Sep 9, 2019
Merged

Fixing Lint #33

merged 6 commits into from
Sep 9, 2019

Conversation

maxulysse
Copy link
Member

Many thanks to contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant). These are the most common things requested on pull requests (PRs).

  • Fix MD lint
  • Take ascat version using R library(ASCAT)
  • use workflow.manifest.version to specify workflow version in path to R scripts for control-FREEC and VEP processes

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

…ion to specify workflow version in path to R scripts for control-FREEC and VEP
@maxulysse
Copy link
Member Author

maxulysse commented Sep 6, 2019

I pushed to retrigger github actions, it was totally stuck with checkout not working...
Not fully reliable yet.

@apeltzer apeltzer merged commit dd08e66 into nf-core:dev Sep 9, 2019
@maxulysse maxulysse deleted the BackToLint branch September 9, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants