Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small refactoring #30

Merged
merged 5 commits into from
Sep 3, 2019
Merged

small refactoring #30

merged 5 commits into from
Sep 3, 2019

Conversation

maxulysse
Copy link
Member

  • refactor MapReads (simplified and easier to read)
  • fix choice between inputPairReadsFastQC and inputBAMFastQC channels
  • fix github actions for branch protection
  • small code polishing

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/sarek/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse self-assigned this Sep 3, 2019
@maxulysse maxulysse added enhancement New feature or request bug Something isn't working labels Sep 3, 2019
@maxulysse maxulysse requested a review from a team September 3, 2019 14:37
@maxulysse maxulysse merged commit 1547a31 into nf-core:dev Sep 3, 2019
@maxulysse maxulysse deleted the refactorMapping branch September 3, 2019 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer approved these changes

Assignees

@maxulysse maxulysse

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @apeltzer