Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dsl2 variant #285

Merged
merged 76 commits into from
Oct 20, 2020
Merged

Dsl2 variant #285

merged 76 commits into from
Oct 20, 2020

Conversation

maxulysse
Copy link
Member

  • Trying to get CI to work again
  • Trying to get nf-core lint . to work again
  • Getting conda to work
  • Simplifying the main container

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

FriederikeHanssen
FriederikeHanssen reviewed Sep 29, 2020
View reviewed changes
environment.yml Outdated Show resolved Hide resolved
environment.yml Outdated Show resolved Hide resolved
modules/local/functions.nf Show resolved Hide resolved
@maxulysse
MAPPING as a separate workflow
b7d3f9e
@maxulysse
MARKDUPLICATES as a module
b675300
@maxulysse
fix: process without container
3149c4c
@maxulysse
fix: --step prepare_recalibration
384c9b6
@maxulysse
fix: --skip_markduplicates
7c38825
@maxulysse
fix: typo
93a15ec
@maxulysse
add: PREPARE_RECALIBRATION as a module
6d1f534
@maxulysse
fix: test_annotation profile fix from dev
9c563c0
@maxulysse
minor code polish
334ce4a
@maxulysse
fix: restore --step variantcalling ci test
4bbc401
@maxulysse
update modules.config
b9f4d08
@maxulysse
use modules.config
5605fa8
@maxulysse
add comments on take inputs
aec9bc5
@maxulysse
improve mapping subworkflow
8bd3179
@maxulysse
improve markduplicates subworkflow
1d3ef0f
@maxulysse
improve prepare_recalibration subworkflow
cb1041c
@maxulysse
use container and conda directive
298a499
@maxulysse
improve reusability of module
ecc0912
@maxulysse
add: RECALIBRATE as a module
224c911
@maxulysse
add: RECALIBRATE as a module + code improvment
55eaf76
@maxulysse
fix: correct usage of --save_bam_mapped
271b8dd
@maxulysse maxulysse marked this pull request as draft October 8, 2020 08:12
FriederikeHanssen
FriederikeHanssen reviewed Oct 20, 2020
View reviewed changes
modules/local/process/bwamem2_mem.nf
params.options = [:]
def options = initOptions(params.options)

environment = params.enable_conda ? "bioconda::bwa-mem2=2.0 bioconda::samtools=1.10" : null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: BWA-Mem2 was updated a couple of days ago to a new release 2.1. It is in conda already, but as far as I saw the biocontainers are not updated yet. Apparently, the new release reduces index size quiet a bit :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, I'll keep a look at the containers.

@maxulysse maxulysse marked this pull request as ready for review October 20, 2020 15:21
@maxulysse maxulysse merged commit 5b2935c into nf-core:dsl2 Oct 20, 2020
@maxulysse maxulysse deleted the dsl2_variant branch October 20, 2020 15:25
chelauk added a commit that referenced this pull request Jan 16, 2021
@chelauk
still reverting
d88a533 
Revert "Merge pull request #285 from MaxUlysse/dsl2_variant"

This reverts commit 5b2935c, reversing
changes made to 7f6a57e.
chelauk added a commit that referenced this pull request Jan 16, 2021
@chelauk
reverting
dd852ae 
Revert "Merge pull request #285 from MaxUlysse/dsl2_variant"

This reverts commit 5b2935c, reversing
changes made to 7f6a57e.
@maxulysse maxulysse added the DSL2 label Jan 19, 2021
@maxulysse
Copy link
Member Author

@chelauk what happened here? I'm a bit confused

@chelauk
Copy link
Contributor

chelauk commented Jan 26, 2021 •
edited
Loading

Hi @maxulysse
I am really sorry, I was playing with DSL2, and I didn't realise that I could alter the nf-core/sarek.git branch, but I could and I did I have attempted to restore it to the point where I first messed with it.
Again, my apologies.

@maxulysse
Copy link
Member Author

@chelauk no problem at all, I made a copy of the branch in case, but I assume you have one too.

@chelauk
Copy link
Contributor

chelauk commented Jan 26, 2021

phew! I'll make sure I don't push directly here, and do the usual pull requests if necessary. Yes I have a local copy.
thanks

@maxulysse
Copy link
Member Author

OK, then I'll delete the copy I made, and don't worry, from my point of view, mistake is mine, that should not have been possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @chelauk @FriederikeHanssen