Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve input.md #183

Merged
merged 13 commits into from
Apr 17, 2020
Merged

improve input.md #183

merged 13 commits into from
Apr 17, 2020

Conversation

ggabernet
Copy link
Member

@ggabernet ggabernet commented Apr 15, 2020

Including docs on how to restart the pipeline from later steps in input.md. Improving a bit the docs.

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@ggabernet
Copy link
Member Author

@mGauder do you wanna check if it is a bit clearer now?

docs/input.md Outdated Show resolved Hide resolved
docs/input.md Outdated Show resolved Hide resolved
docs/input.md Outdated Show resolved Hide resolved
docs/input.md Outdated Show resolved Hide resolved
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clearer indeed

ggabernet and others added 4 commits April 16, 2020 09:19
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
docs/input.md Outdated Show resolved Hide resolved
docs/input.md Outdated Show resolved Hide resolved
docs/input.md Outdated Show resolved Hide resolved
docs/input.md Outdated Show resolved Hide resolved
docs/input.md Outdated Show resolved Hide resolved
@ggabernet ggabernet changed the title improve imput.md improve input.md Apr 16, 2020
ggabernet and others added 4 commits April 16, 2020 12:24
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
docs/input.md Outdated Show resolved Hide resolved
Co-Authored-By: Maxime Garcia <maxime.garcia@scilifelab.se>
docs/input.md Outdated Show resolved Hide resolved
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Toppen!

Co-Authored-By: Gisela Gabernet <gisela.gabernet@qbic.uni-tuebingen.de>
@ggabernet
Copy link
Member Author

awesome, I think everything is covered now 😄

@ggabernet
Copy link
Member Author

I would wait for @mGauder feedback, she's back tomorrow, to have another pair of eyes.

@maxulysse
Copy link
Member

OK, I'll wait her approval to merge then ;-)

@maxulysse maxulysse added the docs label Apr 16, 2020
@maxulysse maxulysse added this to the 2.6 milestone Apr 16, 2020
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! 🎉 Thank you for taking the time to update it!

@maxulysse maxulysse merged commit c058c1e into nf-core:dev Apr 17, 2020
@ggabernet ggabernet deleted the inputdoc branch April 17, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants