Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Remove default null in schema #1119

Merged
merged 3 commits into from
Jun 20, 2023
Merged

FIX: Remove default null in schema #1119

merged 3 commits into from
Jun 20, 2023

Conversation

maxulysse
Copy link
Member

Should we have lint for that?

@maxulysse maxulysse mentioned this pull request Jun 19, 2023
Draft
10 tasks
@github-actions
Copy link

github-actions bot commented Jun 19, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 6e638e4

+| ✅ 154 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-19 12:10:52

SusiJo
SusiJo reviewed Jun 20, 2023
View reviewed changes
nextflow_schema.json
"pattern": "^\\S+\\.csv$",
"schema": "assets/schema_input.json",
"description": "Path to comma-separated file containing information about the samples in the experiment.",
"help_text": "A design file with information about the samples in your experiment. Use this parameter to specify the location of the input files. It has to be a comma-separated file with a header row. See [usage docs](https://nf-co.re/sarek/usage#input).\n\nIf no input file is specified, sarek will attempt to locate one in the `{outdir}` directory.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the two linebreaks here intended or should it just be one linebreak?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just moved that part around, so never notice the line breaks, so I'd say that yeah, they are intended

SusiJo
SusiJo approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@SusiJo SusiJo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :)

@maxulysse maxulysse merged commit 0ca0cb2 into nf-core:dev Jun 20, 2023
@maxulysse maxulysse deleted the schema_null branch June 20, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SusiJo SusiJo SusiJo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @SusiJo