Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a default registry outside of profile scope #1019

Merged
merged 2 commits into from
May 11, 2023
Merged

Set a default registry outside of profile scope #1019

merged 2 commits into from
May 11, 2023

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented May 11, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit fdbfcfb

+| ✅ 153 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-11 17:06:07

@FriederikeHanssen
Copy link
Contributor

why do we need this, if it is only used when docker/podman are enabled? (sorry I think I missed a bunch of things when the whole containers thing was changed)

@maxulysse
Copy link
Member Author

That way people not using the docker profile still have the default registry up to date

@maxulysse maxulysse merged commit 9401434 into nf-core:dev May 11, 2023
@maxulysse
Copy link
Member Author

cf cf nf-core/tools#2286

@maxulysse maxulysse deleted the patch-registry branch May 12, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sateeshperi sateeshperi sateeshperi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @FriederikeHanssen @sateeshperi