Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add htseq to environment requirements #209

Merged
merged 5 commits into from
May 29, 2019
Merged

Add htseq to environment requirements #209

merged 5 commits into from
May 29, 2019

Conversation

olgabot
Copy link
Contributor

@olgabot olgabot commented May 29, 2019 •
edited
Loading

Adds HTSeq for expression counting, to environments yaml file

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/rnaseq branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/rnaseq/tree/master/.github/CONTRIBUTING.md

@olgabot olgabot changed the base branch from master to dev May 29, 2019 19:07
apeltzer
apeltzer requested changes May 29, 2019
View reviewed changes
Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just move the changelog part to the 1.4dev section (or create that one in the changelog file).

CHANGELOG.md Outdated
@@ -26,6 +26,7 @@
* subread 1.6.2 -> 1.6.4
* gffread 0.9.9 -> 0.9.12
* multiqc 1.6 -> 1.7
* Add htseq=0.11.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That needs to go up to the section 1.4dev

environment.yml
@@ -25,3 +25,4 @@ dependencies:
- gffread=0.9.12
- deeptools=3.2.0
- multiqc=1.7
- htseq=0.11.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@apeltzer apeltzer merged commit 9d44294 into nf-core:dev May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeltzer apeltzer apeltzer requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olgabot @apeltzer