Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: include tar in bcl2fastq and bclconvert #3311

Merged
merged 9 commits into from
Apr 24, 2023

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Apr 21, 2023

  • include tar in bcl2fastq and bclconvert modules + remove untar from bcl_demultiplex subworkflow

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@matthdsm
Copy link
Contributor

I'm not sure I like bcl* being $args3 here. One would expect ext.args for a bcl* module to affect the "main" executable and not the ancillary one(s)

@maxulysse maxulysse marked this pull request as ready for review April 24, 2023 06:47
@maxulysse maxulysse added this pull request to the merge queue Apr 24, 2023
Merged via the queue into nf-core:master with commit 878e2b1 Apr 24, 2023
@maxulysse maxulysse deleted the demultiplex branch November 23, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants