Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix awsfulltest.yml #47

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Fix awsfulltest.yml #47

merged 2 commits into from
Mar 23, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 23, 2022

Don't overwrite tower-action defaults for pipeline and git sha.

This will be in the next template release here: nf-core/tools#1488

But can merge now to test ahead of that.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/hicar branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Don't overwrite tower-action defaults for pipeline and git sha.
@ewels ewels requested a review from jianhong March 23, 2022 19:04
@nf-core nf-core deleted a comment from github-actions bot Mar 23, 2022
@github-actions
Copy link

github-actions bot commented Mar 23, 2022

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit f04d8ae

+| ✅ 141 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.1
  • Run at 2022-03-23 19:04:53

@jianhong jianhong merged commit 513574f into master Mar 23, 2022
@ewels ewels deleted the fix-tower-action branch March 24, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants