Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to download 10X Genomics data #146

Merged
merged 11 commits into from
Apr 26, 2023
Merged

Add support to download 10X Genomics data #146

merged 11 commits into from
Apr 26, 2023

Conversation

drpatelh
Copy link
Member

Closes #144

Just need to push the changes to the nf-core/module upstream and re-install in the pipeline, otherwise this should work. Be great if you can test my branch @FelixKrueger to confirm.

@drpatelh drpatelh mentioned this pull request Apr 26, 2023
Closed
7 tasks
@github-actions
Copy link

github-actions bot commented Apr 26, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b47cab1

+| ✅ 153 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: lib/WorkflowFetchngs.groovy
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.7.2
  • Run at 2023-04-26 12:57:13

@FelixKrueger
Copy link

FelixKrueger commented Apr 26, 2023 •
edited
Loading

Hi @drpatelh,

Very elegant changes, a lot less clunky.

I have just run your pipeline using fixes branch, and it works just fine! Thanks a lot for taking quick action!

@maxulysse maxulysse mentioned this pull request Apr 26, 2023
Merged
14 tasks
@drpatelh
Copy link
Member Author

@FelixKrueger @maxulysse please feel free to review, approve and merge when the tests pass!

@drpatelh drpatelh merged commit 2de83c7 into nf-core:dev Apr 26, 2023
@drpatelh drpatelh deleted the fixes branch May 5, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drpatelh @FelixKrueger @maxulysse